Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert pr 587 failed to parse WHERE / GROUP BY clauses in a SELECT statement without a FROM table #597

Merged
merged 2 commits into from
Oct 31, 2019
Merged

revert pr 587 failed to parse WHERE / GROUP BY clauses in a SELECT statement without a FROM table #597

merged 2 commits into from
Oct 31, 2019

Conversation

tiancaiamao
Copy link
Collaborator

Revert #587

@tiancaiamao tiancaiamao requested a review from a team October 31, 2019 07:26
@ghost ghost requested review from tangenta and removed request for a team October 31, 2019 07:27
@tiancaiamao
Copy link
Collaborator Author

PTAL @tangenta @kennytm

@codecov
Copy link

codecov bot commented Oct 31, 2019 •
edited
Loading

Codecov Report

Merging #597 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   79.75%   79.75%   -0.01%     
==========================================
  Files          32       32              
  Lines       12489    12508      +19     
==========================================
+ Hits         9961     9976      +15     
- Misses       1939     1942       +3     
- Partials      589      590       +1
Impacted Files Coverage Δ
parser.go 92.65% <ø> (-0.02%) ⬇️
ast/dml.go 73.85% <100%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8839bb5...68d1416. Read the comment docs.

kennytm
kennytm reviewed Oct 31, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(Please reopen #115 after this is merged)

@kennytm kennytm added the status/LGT1 LGT1 label Oct 31, 2019
qw4990
qw4990 approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao tiancaiamao merged commit bfb0c3a into pingcap:master Oct 31, 2019
@tiancaiamao tiancaiamao deleted the revert-587 branch October 31, 2019 08:10
tiancaiamao added a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@tiancaiamao
revert pr 587 failed to parse WHERE / GROUP BY clauses in a SELECT st…
6f89c95 
…atement without a FROM table (pingcap#597)
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@tiancaiamao
revert pr 587 failed to parse WHERE / GROUP BY clauses in a SELECT st…
17676fe 
…atement without a FROM table (pingcap#597)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@qw4990 qw4990 qw4990 approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
status/LGT1 LGT1 type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiancaiamao @kennytm @qw4990